python-sql

Bug 59

classification
Title: The idiom str(table)[1:-1] used in the AliasManager is wrong
Type: rfe Severity: normal
Components: Versions:
process
Status: closed Resolution: invalid
Dependencies: Superseder:
Assigned To: ced Nosy List: ced, nicoe, roundup-bot
Priority: normal Keywords: patch

Created on 2018-04-27 10:21 by nicoe, last changed 2018-07-06 09:55 by ced.

Messages
msg68 Author: [hidden] (nicoe) Date: 2018-04-27 10:21
It won't work when the table is defined in a schema

See:
https://codereview.tryton.org/38201002/diff/1/sql/__init__.py#newcode698
msg69 Author: [hidden] (ced) Date: 2018-04-27 12:25
I think it was introduced because SQLite does not support
alias on UPDATE and INSERT queries
https://sqlite.org/lang_insert.html
https://sqlite.org/lang_update.html
msg77 Author: [hidden] (ced) Date: 2018-06-25 15:17
For me, there is no issue because the alias is latter
surrounded back by the quotes.
To be sure, I wrote some tests in review42251002
msg78 Author: [hidden] (roundup-bot) Date: 2018-07-06 09:54
New changeset 53fcdbdf7f7f by C├ędric Krier in branch 'default':
Test insert and update with schema
https://hg.tryton.org/python-sql/rev/53fcdbdf7f7f
History
Date User Action Args
2018-07-06 09:55:15cedsetresolution: invalid
2018-07-06 09:54:59roundup-botsetstatus: open -> closed
nosy: + roundup-bot
messages: + msg78
2018-06-25 15:17:19cedsetstatus: new -> open
assignee: ced
type: behavior -> rfe
messages: + msg77
keywords: + patch
2018-04-27 12:25:49cedsetnosy: + ced
messages: + msg69
2018-04-27 10:21:30nicoecreate